Add permission tests for foreman_salt #16962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
added
CherryPick
|
Can one of the admins verify this patch? |
ogajduse
approved these changes
Nov 21, 2024
lhellebr
reviewed
Nov 21, 2024
|
ACK if the one question is answered satisfactorily. |
dosas
force-pushed
the
salt-permissions
branch
from
f0d481a to
c4aa30c
Compare
lhellebr
approved these changes
Nov 21, 2024
dosas
force-pushed
the
salt-permissions
branch
from
c4aa30c to
d389d12
Compare
pondrejk
approved these changes
Nov 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit 4e276e0)
This was referenced Nov 22, 2024
lhellebr
pushed a commit
that referenced
this pull request
Nov 28, 2024
Add permission tests for foreman_salt (#16962) (cherry picked from commit 4e276e0) Co-authored-by: dosas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Missing foreman_salt permissions
Solution
Add permissions
Related Issues
similar to #16892
relevant tests: tests/foreman/api/test_permission.py