Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin wrapanapi version from requirements file #17049

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Unpin wrapanapi version from requirements file #17049

merged 1 commit into from
Dec 3, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Dec 3, 2024

Problem Statement

Robottelo uses wrapanapi and currently it is pinned to version 3.6.4. Since we are always using latest version of wrapanapi so pinning to version needs to be updated whenever wrapanapi releases a new version.

Solution

Unpinned wrapanapi to always use the latest version in robottelo.

Related Issues

@shweta83 shweta83 self-assigned this Dec 3, 2024
@shweta83 shweta83 requested a review from a team as a code owner December 3, 2024 09:57
@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 3, 2024
@shweta83
Copy link
Contributor Author

shweta83 commented Dec 3, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_computeresource_azurerm.py::TestAzureRMFinishTemplateProvisioning::test_positive_azurerm_host_provisioned

@shweta83 shweta83 requested a review from jyejare December 3, 2024 09:59
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9508
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_computeresource_azurerm.py::TestAzureRMFinishTemplateProvisioning::test_positive_azurerm_host_provisioned --external-logging
Test Result : ================= 1 passed, 13 warnings in 1719.28s (0:28:39) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 3, 2024
@jyejare jyejare added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 and removed 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 3, 2024
@jyejare jyejare merged commit bb2f884 into SatelliteQE:master Dec 3, 2024
22 of 23 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
@shweta83 @web-flow
Unpin wrapanapi version from requirements file (#17049)
ee71b31 
Unpin wrapanapi version

(cherry picked from commit bb2f884)
This was referenced Dec 3, 2024
Closed
Closed
Merged
Closed
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 3, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
98968df 
Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 3, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
5481a89 
Unpin wrapanapi version
@Gauravtalreja1
Copy link
Collaborator

@shweta83 @jyejare Why are we using unpinned dependencies in requirements when we have dependabot to update them on a regular basis?

@jyejare
Copy link
Member

jyejare commented Dec 3, 2024

Dependabot only opens the update PR if the requirement is not pinned or may be when it sets to greater than some pinned version.

For now wrapanapi was pinned and hence dependabot was not opening a update PR for it.

shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
4e4f9b0 
Unpin wrapanapi version
jyejare pushed a commit that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (#17049) (#17054)
424cccf 
Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
7daad68 
Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
b2ee2e9 
Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
9ce06aa 
Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
3c2d4f0 
Unpin wrapanapi version
jyejare pushed a commit that referenced this pull request Dec 4, 2024
@shweta83
[6.15.z]Unpin wrapanapi version from requirements file (#17070)
9f04946 
Unpin wrapanapi version from requirements file (#17049)

Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
b572a15 
Unpin wrapanapi version
shweta83 added a commit to shweta83/robottelo that referenced this pull request Dec 4, 2024
@shweta83
Unpin wrapanapi version from requirements file (SatelliteQE#17049)
3ad6ee1 
Unpin wrapanapi version
jyejare pushed a commit that referenced this pull request Dec 4, 2024
@shweta83
[6.14.z]Unpin wrapanapi version from requirements file (#17049) (#17071)
dd032a1 
Unpin wrapanapi version from requirements file (#17049)

Unpin wrapanapi version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare Awaiting requested review from jyejare

Assignees

@shweta83 shweta83

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shweta83 @Satellite-QE @Gauravtalreja1 @jyejare