Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission read test skipped #17080

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Dec 5, 2024

Problem Statement

Solution

Changed the test so it doesn't just check the first perm, associated a related JIRA

Related Issues

@pondrejk pondrejk added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 5, 2024
@pondrejk pondrejk self-assigned this Dec 5, 2024
@pondrejk pondrejk requested a review from a team as a code owner December 5, 2024 09:14
@vsedmik
Copy link
Contributor

vsedmik commented Dec 5, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_multiple_path.py -k test_positive_permission_read

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely looks good to me, PRT pending.

@pondrejk pondrejk merged commit 06c9b26 into SatelliteQE:master Dec 6, 2024
9 of 10 checks passed
assert perm.name
assert perm.resource_type
perms = target_sat.api.Permission().search(query={'per_page': '1'})
for perm in perms:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no result, this test will pass. Should it assert there's at least one entry by using assert perms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants