Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated 6.16 reporting tests #17117

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix outdated 6.16 reporting tests #17117

merged 1 commit into from
Dec 10, 2024

Conversation

LadislavVasina1
Copy link
Contributor

Problem Statement

There were multiple outdated Reporting UI tests that did not work correctly with 6.16.

Solution

This PR fixes these issues.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k "test_positive_generate_subscriptions_report_json or test_positive_schedule_generation_and_get_mail"

@LadislavVasina1 LadislavVasina1 added UI Issues and PRs involving the UI No-CherryPick PR doesnt need CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 9, 2024
@LadislavVasina1 LadislavVasina1 self-assigned this Dec 9, 2024
@LadislavVasina1 LadislavVasina1 requested a review from a team as a code owner December 9, 2024 16:40
@LadislavVasina1
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k "test_positive_generate_subscriptions_report_json or test_positive_schedule_generation_and_get_mail"

@LadislavVasina1 LadislavVasina1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 9, 2024
Gauravtalreja1
Gauravtalreja1 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, @LadislavVasina1 If is this change intended for 6.16.z and stream, you might want to replace No-cherrypick label with Cherrypick label to get this picked to 6.16.z?

@LadislavVasina1
Copy link
Contributor Author

LadislavVasina1 commented Dec 10, 2024 •
edited
Loading

@Gauravtalreja1 I already have target branch set to 6.16.z

This PR is not intended for stream.

@ogajduse ogajduse merged commit e413d30 into SatelliteQE:6.16.z Dec 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ogajduse ogajduse ogajduse approved these changes

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

Assignees

@LadislavVasina1 LadislavVasina1

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LadislavVasina1 @ogajduse @Gauravtalreja1 @vsedmik