pin wrapnapi to force dependency errors to become more visible #17166
Conversation
evgeni
added
CherryPick
evgeni
force-pushed
the
force-azure
branch
2 times, most recently
from
cfb3a3a to
3a4fc91
Compare
evgeni
changed the title
requirements.txt
Outdated
|
|
||
| # Get airgun, nailgun and upgrade from master | ||
| airgun @ git+https://github.com/SatelliteQE/airgun.git@master#egg=airgun | ||
| airgun @ git+https://github.com/SatelliteQE/airgun.git@00075a209e24df0e77c18b484631485bfc10f54f#egg=airgun |
There was a problem hiding this comment.
Hmm, I don't understand this fix. Won't it block us from using latest code?
There was a problem hiding this comment.
Sure. But the latest code doesn't install, which mean's right now, we can't use it anyway.
(We can also go an revert that selenium bump in airgun, and then implement CI in airgun that checks that robottelo still works after an airgun change)
There was a problem hiding this comment.
So this is a temporary fix? The second option sounds like a lot of work but a proper fix.
There was a problem hiding this comment.
Lets hold the selenium bump in airgun. If we limit ourselves for airgun here then all the other fixes made in airgun wont be applied in robottelo and test fixed by airgun would fail.
There was a problem hiding this comment.
Is this time to start digging in wrapanapi?
There was a problem hiding this comment.
Probably depends on how many pitchforks and shovels you have on a Friday.
Reverting that airgun commit (and ensuring dependabot doesn't recreate that mess again) is probably a good enough fix for a Friday.
And then we can go and see how to fix wrapanapi to be compatible with dependencies released after 2017 ;-)
There was a problem hiding this comment.
So this is a quick fix I made. It's a long time since I've played with dependencies and dependabot, please check if I didn't screw up something.
SatelliteQE/airgun#1668
There was a problem hiding this comment.
Sounds like a plan. Acked, but I'm not yet high ranking enough to merge it:)
requirements.txt
Outdated
|
|
||
| # Get airgun, nailgun and upgrade from master | ||
| airgun @ git+https://github.com/SatelliteQE/airgun.git@master#egg=airgun | ||
| airgun @ git+https://github.com/SatelliteQE/airgun.git@00075a209e24df0e77c18b484631485bfc10f54f#egg=airgun |
There was a problem hiding this comment.
Lets hold the selenium bump in airgun. If we limit ourselves for airgun here then all the other fixes made in airgun wont be applied in robottelo and test fixed by airgun would fail.
Related: SatelliteQE/robottelo#17166 (cherry picked from commit 7b279d5)
evgeni
changed the title
pin wrapanapi (cherry picked from commit 81f3ee7)
pin wrapanapi (cherry picked from commit 81f3ee7)
pin wrapanapi (cherry picked from commit 81f3ee7)
Related: SatelliteQE/robottelo#17166 (cherry picked from commit 7b279d5) Co-authored-by: Lukáš Hellebrandt <[email protected]>
…le (#17169) pin wrapnapi to force dependency errors to become more visible (#17166) pin wrapanapi (cherry picked from commit 81f3ee7) Co-authored-by: Evgeni Golov <[email protected]>
…le (#17170) pin wrapnapi to force dependency errors to become more visible (#17166) pin wrapanapi (cherry picked from commit 81f3ee7) Co-authored-by: Evgeni Golov <[email protected]>
…le (#17168) pin wrapnapi to force dependency errors to become more visible (#17166) pin wrapanapi (cherry picked from commit 81f3ee7) Co-authored-by: Evgeni Golov <[email protected]>
Problem Statement
airgun bumped the selenium dep, which updates websocket-client to a version that's not compatible with the ancient openshift/kubernetes used by wrapanapi (https://github.com/openshift/openshift-restclient-python/blob/release-0.3.4/requirements.txt#L3, https://github.com/kubernetes-client/python/blob/release-3.0/requirements.txt#L9).
as we don't pin wrapanapi, the depsolver tries to find a version that works, and picks one that has azure unpinned (2.7.0!).
this gets us azure 5.0.0, but azure 5.0.0 deprecated the
azuremeta package in favor of service specific packages prefixed byazure-and errors out when you try to install it.Solution
Related Issues