Added ordinal function for correct number endings (1st 2nd 3rd) #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When image download messages are printing out (primarily in the CoastSeg messages cell beneath the main map in the
ipynb
), the same ordinal number ending is used for all numbers of images in a list. As a result, the first few printouts incorrectly read "Downloading 1th image ... Downloading 2th image ... Downloading 3th image".A short function
ordinal(n)
has been added toSDS_tools
to return the correct ordinal ending (1st 2nd 3rd) for any number being used in update printouts. This function has then been implemented throughoutSDS_download
. This update looks like this in practice:desc=f"{inputs['sitename']}, {satname}: Downloading tif for {i}th image ",
changed to
desc=f"{inputs['sitename']}, {satname}: Downloading tif for {SDS_tools.ordinal(i)} image ",