remove redundant else

Sauceforge · Sep 6, 2024 · 9cac542 · 9cac542
1 parent ada3e83
commit 9cac542
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 20 deletions.
diff --git a/Saucery.Core/Dojo/DojoExtensions.cs b/Saucery.Core/Dojo/DojoExtensions.cs
@@ -320,13 +320,11 @@ public static BrowserVersion Classify(this BrowserVersion browserVersion)
             browserVersion.PlatformType = PlatformType.Android;
             return browserVersion;
         }
-        else
+
+        if (browserVersion.IsAnAppleDevice())
         {
-            if (browserVersion.IsAnAppleDevice())
-            {
-                browserVersion.PlatformType = PlatformType.Apple;
-                return browserVersion;
-            }
+            browserVersion.PlatformType = PlatformType.Apple;
+            return browserVersion;
         }
 
         //Desktop

diff --git a/Saucery.Core/Dojo/PlatformConfigurator.cs b/Saucery.Core/Dojo/PlatformConfigurator.cs
@@ -134,15 +134,15 @@ public List<BrowserVersion> FilterAll(List<SaucePlatform> platforms)
             return ValidateReal(platform) != null 
                 ? new BrowserVersion(platform) 
                 : null;
-        } else {
-            var bv = Validate(platform);
-            if(bv != null) {
-                bv.ScreenResolution = platform.ScreenResolution;
-                bv.DeviceOrientation = platform.DeviceOrientation;
-            }
-
-            return bv;
         }
+
+        var bv = Validate(platform);
+        if(bv != null) {
+            bv.ScreenResolution = platform.ScreenResolution;
+            bv.DeviceOrientation = platform.DeviceOrientation;
+        }
+
+        return bv;
     }
 
     public BrowserVersion? Validate(SaucePlatform requested)

diff --git a/Saucery.Core/OnDemand/PlatformClassifer.cs b/Saucery.Core/OnDemand/PlatformClassifer.cs
@@ -12,13 +12,11 @@ public static SaucePlatform Classify(this SaucePlatform platform)
             platform.PlatformType = PlatformType.Android;
             return platform;
         }
-        else
+
+        if (platform.IsAnAppleDevice())
         {
-            if (platform.IsAnAppleDevice())
-            {
-                platform.PlatformType = PlatformType.Apple;
-                return platform;
-            }
+            platform.PlatformType = PlatformType.Apple;
+            return platform;
         }
 
         //Desktop