-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐Bug Fix: Entire section of the heading "AEC LIBRARY", on click links to "index.html" , in "resource.html" #1476
base: main
Are you sure you want to change the base?
⭐Bug Fix: Entire section of the heading "AEC LIBRARY", on click links to "index.html" , in "resource.html" #1476
Conversation
… should link to 'index.html' instead of it's entire section, In resource.html
✅ Deploy Preview for aec-library-wbsite ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since we already have Back to Home
, we should remove the nav link from the header...
Also next time make sure you add smaller PR title(If you want to add description add it as a comment), PR title should be short and apt for what you have done.
Thank you for pointing it out @rohanbabbar04 , next time I will make sure to add smaller PR title . |
You have merge conflicts, do resolve.. |
I hope the merge conflict was resolved, @rohanbabbar04. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!
🛠️ Fixes Issue
Fixes #1469 by @DefinitelyObsessed
👨💻 Changes proposed
In resource.html Fixed :
✔️ Check List (Check all the applicable boxes)
📷 Screenshots