Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐Bug Fix: Entire section of the heading "AEC LIBRARY", on click links to "index.html" , in "resource.html" #1476

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DefinitelyObsessed
Copy link
Contributor

🛠️ Fixes Issue

Fixes #1469 by @DefinitelyObsessed

👨‍💻 Changes proposed

In resource.html Fixed :

  • On click, only heading "AEC LIBRARY" links to "index.html" ,
  • So only on hovering over heading "AEC LIBRARY", pointer is 'cursor pointer', instead of it's entire section, In "resource.html"

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📷 Screenshots

Before After
OpSo#6 before-img OpSo#6 after-img

… should link to 'index.html' instead of it's entire section, In resource.html
@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for aec-library-wbsite ready!

Name Link
🔨 Latest commit 82cd04e
🔍 Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64d66bc5a2e78b000815de53
😎 Deploy Preview https://deploy-preview-1476--aec-library-wbsite.netlify.app/resource
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rohanbabbar04 rohanbabbar04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we already have Back to Home, we should remove the nav link from the header...

Also next time make sure you add smaller PR title(If you want to add description add it as a comment), PR title should be short and apt for what you have done.

@DefinitelyObsessed
Copy link
Contributor Author

Thank you for pointing it out @rohanbabbar04 , next time I will make sure to add smaller PR title .

@rohanbabbar04
Copy link
Collaborator

You have merge conflicts, do resolve..

@DefinitelyObsessed
Copy link
Contributor Author

I hope the merge conflict was resolved, @rohanbabbar04.
Thank you for pointing it out .

Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants