29 allow button size change #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the TypeScript version to 3.8.3 (note that this is not the latest version as of this commit). 3.8.3 doesn't have the spread operator bug. The build was failing with this message: ``` button-text-card/src/button-text-card.ts(53,7): semantic error TS2783: 'title' is specified more than once, so this usage will be overwritten. ``` Added vscode exclusions to gitignore.
…one/button-text-card into kenstone-fix-typescript-build-error # Conflicts: # dist/button-text-card.js # dist/button-text-card.js.map
- Added support for custom icon_size
Adds Savjee#29. New properties on the button `width`,`height`. By default the fields are set to 85px. Properties are on the actual button part of the card, not the card as a whole. Also, changed cursor to `pointer` when using a mouse. Slight tweaks to README
Adds Savjee#29. New properties on the button `width`,`height`. By default the fields are set to 85px. Properties are on the actual button part of the card, not the card as a whole. Also, changed cursor to `pointer` when using a mouse. Slight tweaks to README
…tone/button-text-card into 29-allow-button-size-change
Savjee
reviewed
Jun 22, 2020
| @@ -278,6 +288,7 @@ export class BoilerplateCard extends LitElement { | |||
| box-shadow: 2px 2px rgba(0, 0, 0, 0); | |||
| padding: 16px; | |||
| outline: none; | |||
| cursor: pointer; | |||
There was a problem hiding this comment.
Good idea but I think we should only add this when the user defined a tap_action or entity.
| @@ -53,7 +54,9 @@ export class BoilerplateCard extends LitElement { | |||
| name: 'Button Text Card', | |||
| title: '', | |||
| subtitle: '', | |||
| height: '85px', | |||
There was a problem hiding this comment.
For icon_size we don't require users to add px.
I think we shouldn't do it here either to stay uniform. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to specify the width, height of the button
Closes #29. New properties on the button
width,height. By defaultthe fields are set to 85px. Properties are on the actual button part
of the card, not the card as a whole.
Also, changed cursor to
pointerwhen using a mouse.Slight tweaks to README