Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Contract/Component hooks and add tests #125

Merged
merged 18 commits into from
Aug 26, 2024

Conversation

gianalarcon
Copy link
Collaborator

@gianalarcon gianalarcon commented Aug 23, 2024

Task name here

  • Implement custom IERC721MetadataCamelOnly

  • Use Cairo hooks

    • Add ERC721Enumerable component
    • Remove fn _before_transfer() and many override functions. Implement Hooks::before_update
    • Remove custom fn _transfer_from(). Use oz transfer_from()
    • Remove custom fn _mint(). Use oz mint()
  • Create folder for components

  • Expand test coverage.

Types of change

  • Feature
  • Enhancement

Comments (optional)

  • safe_mint works in sepolia but fails in devnet

@gianalarcon gianalarcon marked this pull request as ready for review August 24, 2024 06:35
@gianalarcon gianalarcon marked this pull request as draft August 25, 2024 04:51
@gianalarcon gianalarcon marked this pull request as ready for review August 25, 2024 08:09
@gianalarcon gianalarcon marked this pull request as draft August 25, 2024 14:14
@gianalarcon gianalarcon marked this pull request as ready for review August 25, 2024 15:49
@0xquantum3labs 0xquantum3labs merged commit abdbeca into challenge-0-simple-nft Aug 26, 2024
1 check passed
@0xquantum3labs 0xquantum3labs deleted the contract/hooks branch August 26, 2024 16:03
@0xquantum3labs 0xquantum3labs restored the contract/hooks branch August 26, 2024 16:03
@0xquantum3labs 0xquantum3labs deleted the contract/hooks branch August 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants