handle accented filenames on internal files #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble with epubx handling a book and tracked it down to accented characters in the internal filenames.
See this screenshot of the internal filenames inside the file.
The problem is that the filenames are sent through Uri.decodeFull(), which throws an
Invalid argument(s): Illegal percent encoding in URI
on encountering an accent.
I put some code in that checked for the error and if there was an error on Uri.decodeFull returns the fileName with no change.
The problem with what I added is that it does not cover the case that you have accented chars and encoded url filenames, but I thought it could be a start of something eventually useful. It is covering me on these filenames which do have accents but no spaces etc that Uri.decodeFull() helps with.