Support whitespaces in definitions #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to support Rails 6.1 which now has
t.check_constraint "some long statement", but I am too unfamiliar with the development environment to include Rails-version specific code; so for now, I just deduced (and tested on a local project) that solving #16 will help.The fix is to use more robust regexp for column name detection in Rails-generated statements.
The PR seems to work, both practically (when included locally in Rails 6.1+ project with constraints in DB), and in tests that are related to my changes.
I am not sure why SQLite tests fail on CI, but I am almost sure that it is unrelated:
Please advise how to proceed with this PR.