Whitespace and sort order for Dumper Middleware

[pik]

Currently the schema_plus_enum dumper will dump in the following format:

ActiveRecord::Schema.define(version: 0) do

  # These are extensions that must be enabled in order to support this database
  enable_extension "plpgsql"


create_enum "color", "cyan", "magenta", "yellow", "black", :schema => "cmyk"
create_enum "aaaa", "1", "2", "3"
create_enum "bar", "1", "2", "3"
create_enum "color", "cyan", "magenta", "yellow", "black"
create_enum "foo", "foo", "FOO", "bar"
  create_table "test", force: :cascade do |t|
    t.integer "col1"
  end

end

Correctly I think this should look like so, where schema being visually represented as a secondary key should perhaps also be first ordered by enum_name as a they key - (not sure about this one).

Will update and add some additional specs if this looks sensible.

[pik]

Not sure if we would ever have more than one level of nesting on Initial and whether this should be evaluated to account for that possibility?

[ronen]

I haven't worried about that so far :)

[ronen]

Looks good, thanks. What do you think about the its suggestion?

[ronen]

I've gone ahead and merged this, then added my cleanup and also added a spec to verify the sort order.

I've pushed release v0.1.1 with this in it.

Thanks again

[pik]

Thanks, apologies for not keeping up during the week. When you have sometime do you think you could update the discussion here: #2 (comment)

I'm still hoping there might be a way to do this given the existing ActiveRecord code - but if you don't see a way of doing so it might make sense to open a discussion on the rails mailing list.

[ronen]

When you have sometime do you think you could update the discussion here: #2 (comment)

yep, done.

... open a discussion on the rails mailing list.

I don't think that's necessary for this case.

That said, as a general statement of principle I'd be completely happy for anything and everything added by the schema_plus family to be supported natively in AR. In my ideal world, schema_plus would have no need to exist! :)