Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(youtrack-app): add JetBrains YouTrack App schema #4048

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

skoch13
Copy link
Contributor

@skoch13 skoch13 commented Sep 4, 2024

No description provided.

@github-actions github-actions bot added the ci ".github/**/*" folder is updated (auto-generated by labeler action) label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@skoch13 skoch13 changed the title feat(youtrack-app): add YouTrack App schema feat(youtrack-app): add JetBrains YouTrack App schema Sep 4, 2024
@hyperupcall
Copy link
Member

hyperupcall commented Sep 4, 2024

Thanks!

Just a heads up, there are already several other schemas in the catalog that match manifest.json, so it's likely that the schema won't automatically be inferred by file name. Usually, we never allow fileMatches to conflict for this reason, but manifest.json is something that always has been messed up so I'll be able to merge this. (these types of issues are tracked by #3658 and partially #3965).

Another heads up, there seems to be an issue when GitHub teams are specified in the CODEOWNERS file. There is more information in this comment, but if I recall correctly, the issue is that valid permissions/authentication is required to access the team members of a particular team. So until that is fixed it might be good to specify usernames as well.

cc @skoch13

@hyperupcall hyperupcall merged commit e8da619 into SchemaStore:master Sep 4, 2024
3 checks passed
@skoch13 skoch13 deleted the feature-youtack-app branch September 5, 2024 06:00
@skoch13
Copy link
Contributor Author

skoch13 commented Sep 5, 2024

Thank you!

Just a heads up, there are already several other schemas in the catalog that match manifest.json.

Got it. I'll omit fileMatch completely then.

Another heads up, there seems to be an issue when GitHub teams are specified in the CODEOWNERS file.

The team I initially specified is public; however, we're good to specify particular usernames instead to proceed.

Once again, thank you for the detailed reply and your work!

@hyperupcall
Copy link
Member

Once again, thank you for the detailed reply and your work!

You're welcome!

benpops89 pushed a commit to benpops89/schemastore that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci ".github/**/*" folder is updated (auto-generated by labeler action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants