Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nitro.json to catalog (self-hosted) #4260

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

mrousavy
Copy link
Contributor

@mrousavy mrousavy commented Dec 5, 2024

A follow up PR to #4257 - but I self-host the nitro.schema.json file on Nitro's official website instead of the schema store.

nitro.json is for https://github.com/mrousavy/nitro - a library for bridging JS code to C++/Swift/Kotlin. Used to create react native modules.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

Thanks! Unfortunately I cannot merge with that fileMatch because it conflicts with NuxtJS. Maybe there's another name you can use? I can also merge with fileMatch: []

@mrousavy
Copy link
Contributor Author

mrousavy commented Dec 6, 2024

Ah well that sucks, didn't know. Is that deprecated on their end or still active?

I will use nitro.json as a config, so if it conflicts then we can't really add it here, sorry but thanks anyways!

@mrousavy
Copy link
Contributor Author

mrousavy commented Dec 6, 2024

Hm, from the code you sent it seems like this was only there for backwards compatibility - after searching for nitro.json in there codebase I can't find any results - not sure if they still use that config name?

@hyperupcall
Copy link
Member

hyperupcall commented Dec 7, 2024

Oops, that was the wrong link. nitro.json is used here, by Nitro. (Nuxt.js uses Nitro under the hood). It's also mentioned in the docs:

Nitro loads the configuration using unjs/c12, giving more possibilities such as using .nitrorc

The naming is unfortunate because both projects are reasonably popular. Currently both #3965 and #3658 are potential solutions to solve this (so the schema does not generate false positives)

@mrousavy
Copy link
Contributor Author

mrousavy commented Dec 7, 2024

Gotcha- well that sucks. It's fine tho, Nuxt/Nitro was here first, let's just wait for #3965 and #3658 to allow both depending on root files :)

@hyperupcall
Copy link
Member

In the meantime though, I'm still able to merge this with an empty [] fileMatch field

@mrousavy
Copy link
Contributor Author

mrousavy commented Dec 9, 2024

@hyperupcall sounds good, thanks! Updated it

@hyperupcall hyperupcall merged commit ab8cd67 into SchemaStore:master Dec 9, 2024
3 checks passed
@hyperupcall
Copy link
Member

Awesome thanks

migalons pushed a commit to migalons/schemastore that referenced this pull request Dec 15, 2024
* feat: Add `nitro.json` to catalog (self-hosted)

* Update catalog.json

* Update catalog.json

* Remove filematch for now as it conflicts with nuxt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants