changed UI for dataproducttable and added a sharing feature #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lahirujayathilake , I have no access to the add reviewer option, could you please review this PR? Thanks! |
lahirujayathilake
requested changes
Feb 11, 2025
| @@ -11,14 +11,14 @@ def __init__(self, request_data): | |||
| channel = grpc.insecure_channel('localhost:6565') | |||
| self.stub = data_catalog_pb2_grpc.DataCatalogAPIServiceStub(channel) | |||
| self.user_info = pb2.UserInfo(user_id=request_data['user_id'], tenant_id=request_data['tenant_id']) | |||
|
|
|||
There was a problem hiding this comment.
revert this (and line 21)
| #python -m grpc_tools.protoc -I . --python_out=. --grpc_python_out=. ./data_catalog.proto | ||
| # Generate the DataCatalog Stubs | ||
| python -m grpc_tools.protoc -I "D:/airavata-data-catalog/data-catalog-api/stubs/src/main/proto" --python_out="D:/smiles-django-portal/smiles/proto" --grpc_python_out="D:/smiles-django-portal/smiles/proto" "D:/airavata-data-catalog/data-catalog-api/stubs/src/main/proto/data_catalog.proto" |
There was a problem hiding this comment.
give the relative path instead a specific one
|
|
||
|
|
||
| def extract_request_data(request): | ||
| return { | ||
| 'user_id': str(request.user.id), | ||
| 'tenant_id': "demotenant" | ||
| } | ||
| ################### |
Comment on lines
+256
to
+257
| if not tenant_id: | ||
| tenant_id = "demotenant" # if no tenant_id，assisn to "demotenant" |
There was a problem hiding this comment.
there must be a tenant_id if not throw an error and log the message
| results = {"users": [], "groups": []} | ||
| try: | ||
| # | ||
| with grpc.insecure_channel('localhost:6565') as channel: |
There was a problem hiding this comment.
better to make this host and port be extracted from configurations rather than hardcoding.
If you're doing this change make sure to update the data_catalog_service as well
Comment on lines
+268
to
+269
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.