Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type annotation to step parameters in AutoFiniteDiff #104

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Jan 23, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

#102 added the relstep and absstep parameters without type annotations, which is equivalent to ::Any. This PR fixes it.

@gdalle
Copy link
Collaborator Author

gdalle commented Jan 23, 2025

One question for @ChrisRackauckas / @Vaibhavdixit02 / @avik-pal: will these additional type parameters cause problems if someone used to write AutoFiniteDiff{T1,T2,T3} and expect a concrete type?

@gdalle
Copy link
Collaborator Author

gdalle commented Jan 24, 2025

Since this is a very small change fixing a rather big mistake in a past PR I reviewed, I hope it's okay that I merge it myself. Do let me know if it was not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant