Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interpolations for MIRK methods #112

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Add interpolations for MIRK methods #112

merged 2 commits into from
Sep 23, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Sep 19, 2023

Fix #111

This PR adds interpolations for MIRK methods

Tested on example problem from README:

image

@ErikQQY ErikQQY marked this pull request as ready for review September 20, 2023 05:50
@ErikQQY ErikQQY closed this Sep 20, 2023
@ErikQQY ErikQQY reopened this Sep 20, 2023
@ErikQQY ErikQQY changed the title [WIP]Add interpolations for MIRK methods Add interpolations for MIRK methods Sep 20, 2023
@ChrisRackauckas
Copy link
Member

Can you add a convergence with something like a mid time condition in order test the correctness here?

@avik-pal
Copy link
Member

This only adds interpolation to the solution object, right? We need the intermediate objects passed to the bc to be interpolation-friendly as well.

@ChrisRackauckas
Copy link
Member

Yes, that sol object is what you should just be passing to the bc anyways, just then updating its coefficient vectors as you go along.

@avik-pal
Copy link
Member

This would also be a breaking change, right? We can up the SciMLBase compat to 2.0 and do that together with #109 & SciML/SciMLBase.jl#477

@ChrisRackauckas
Copy link
Member

Why would this be a breaking change?

@avik-pal
Copy link
Member

That changes the input specification to bc. The current specification is a vector of arrays which now changes to a solution similar to shooting.

@ChrisRackauckas
Copy link
Member

It was supposed to always be the solution. The solution type acts as a vector of arrays so the actions are the same, just extended though?

@ChrisRackauckas ChrisRackauckas merged commit 186339d into SciML:master Sep 23, 2023
ChrisRackauckas
ChrisRackauckas reviewed Sep 23, 2023
View reviewed changes
src/adaptivity.jl
@@ -253,7 +253,7 @@ end
w′[(stage + 1):s_star],
true,
true)
z .= z .* dt .+ cache.y₀[i]
z .= z .* dt[1] .+ cache.y₀[i]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this 1 seems odd?

@ErikQQY ErikQQY mentioned this pull request Oct 11, 2023
Closed
@ErikQQY ErikQQY mentioned this pull request Apr 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

@avik-pal avik-pal Awaiting requested review from avik-pal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interoplation for MIRK methods
3 participants
@ErikQQY @ChrisRackauckas @avik-pal