Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solution type from BVPM2 and BVPSOL #140

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Fix solution type from BVPM2 and BVPSOL #140

merged 3 commits into from
Nov 7, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Nov 7, 2023

Now the solution type from ODEInterface.jl is compatible with the others

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Benchmark Results

master 4703860... t[master]/t[4703860...]
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.08 ± 0.14 ms 3.1 ± 0.14 ms 0.996
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 5.64 ± 0.23 ms 5.71 ± 0.25 ms 0.988
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0765 ± 0.0041 s 0.0792 ± 0.0055 s 0.967
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.273 ± 0.0039 s 0.278 ± 0.0058 s 0.984
Simple Pendulum/IIP/Shooting(Tsit5()) 0.281 ± 0.023 ms 0.282 ± 0.025 ms 0.994
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 7.05 ± 0.38 ms 7.16 ± 0.24 ms 0.984
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 12.6 ± 5.9 ms 12.6 ± 6 ms 0.993
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.191 ± 0.0048 s 0.192 ± 0.0067 s 0.994
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 1.08 ± 0.016 s 1.08 ± 0.025 s 0.996
Simple Pendulum/OOP/Shooting(Tsit5()) 1.1 ± 0.066 ms 1.1 ± 0.082 ms 1.01
time_to_load 9.79 ± 0.08 s 9.8 ± 0.07 s 0.999

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Signed-off-by: ErikQQY <[email protected]>
@ChrisRackauckas ChrisRackauckas merged commit fc529de into SciML:master Nov 7, 2023
11 checks passed
@ErikQQY ErikQQY deleted the qqy/eachcol branch November 8, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants