Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AlmostBandedMatrix for MIRK Jacobians #141

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 7, 2023

@avik-pal avik-pal marked this pull request as draft November 7, 2023 20:37
@avik-pal avik-pal force-pushed the ap/faster_mirk branch 5 times, most recently from 4a9ab3f to 9b8a59d Compare November 12, 2023 18:43
@avik-pal avik-pal closed this Nov 12, 2023
@avik-pal avik-pal reopened this Nov 12, 2023
Copy link
Contributor

github-actions bot commented Nov 12, 2023

Benchmark Results

master fe836c3... t[master]/t[fe836c3...]
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.83 ± 0.071 ms 1.86 ± 0.075 ms 0.987
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.41 ± 0.14 ms 3.41 ± 0.11 ms 0.999
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.055 ± 0.0039 s 0.0544 ± 0.0039 s 1.01
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 1.09 ± 0.011 s 1.12 ± 0.02 s 0.969
Simple Pendulum/IIP/Shooting(Tsit5()) 0.178 ± 0.0053 ms 0.179 ± 0.0057 ms 0.991
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 4.41 ± 0.29 ms 4.4 ± 0.38 ms 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 7.87 ± 4.5 ms 7.66 ± 4.6 ms 1.03
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.139 ± 0.0062 s 0.132 ± 0.0043 s 1.05
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 4.82 ± 0.01 s 4.79 ± 0.027 s 1.01
Simple Pendulum/OOP/Shooting(Tsit5()) 0.763 ± 0.035 ms 0.709 ± 0.041 ms 1.08
time_to_load 7.36 ± 0.032 s 8.02 ± 0.033 s 0.918

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal marked this pull request as ready for review November 12, 2023 19:52
@ChrisRackauckas
Copy link
Member

All of the benchmarks are shooting methods?

@avik-pal
Copy link
Member Author

I realized that after the benchmarks ran 😓

@avik-pal
Copy link
Member Author

image

@avik-pal
Copy link
Member Author

Needs a patch for underdetermined systems

@ChrisRackauckas ChrisRackauckas merged commit 54bfc47 into SciML:master Nov 15, 2023
10 of 11 checks passed
@avik-pal avik-pal deleted the ap/faster_mirk branch November 22, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants