added upload args, also hopefully fixed plot embedding

SciML · Oct 28, 2024 · 6d93d6a · 6d93d6a
1 parent e3a9826
commit 6d93d6a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/Documentation.yml b/.github/workflows/Documentation.yml
@@ -36,8 +36,7 @@ jobs:
       # Cache to speed up subsequent runs
       - uses: julia-actions/cache@v2
         with:
-          token: "${{ secrets.GITHUB_TOKEN }}"
-          cache-name: "docs-cache"
+          cache-name: docs-cache
 
       # Install Julia package dependencies for the documentation project
       - name: Install dependencies
@@ -59,8 +58,11 @@ jobs:
       - name: Upload site as artifact
         uses: actions/upload-artifact@v4
         with:
-          name: Docs build
+          name: docs-artifact
           path: ./docs/build
+          retention-days: 2
+          compression-level: 9
+          overwrite: true
 
       - uses: julia-actions/julia-processcoverage@v1
 
@@ -69,3 +71,4 @@ jobs:
           file: lcov.info
           token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: false
+
diff --git a/docs/src/model_simulation/examples/interactive_brusselator_simulation.md b/docs/src/model_simulation/examples/interactive_brusselator_simulation.md
@@ -67,7 +67,6 @@ axislegend(ax, position = :rt)
 
 # Display the figure
 fig
-nothing # hide
 ```
 
 The plot shows the concentrations of species X and Y over time. Notice the oscillatory behavior characteristic of the Brusselator model.
@@ -148,7 +147,6 @@ axislegend(ax, position = :rt)
 
 # Display the figure
 fig
-nothing # hide
 ```
 
 This plot will now update in real-time as you move the sliders, allowing for interactive exploration of the Brusselator's behavior under different conditions. (Note the figure above is not interactive, but for illustrative purposes to show what you should see locally.)