-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup DSL generated expression for readability #1024
cleanup DSL generated expression for readability #1024
Conversation
Looks good. Ideally I'd prefer to not do any non-required changes to the DSL file until after #985 is merged (I've already had to do one messy merge thing to get that one back functioning with master). The removing |
This introduces a bunch of intermediate variables to store inputs to
make_ReactionSystem_internal
, with the goal of making the generated expression easier to read when debugging. It also makes the creation oft
the first thing in the generated code, which should be a first step to allowing time-dependent parameters (something MTK is working on better supporting).