CompatHelper: bump compat for BifurcationKit in [weakdeps] to 0.4, (keep existing compat) #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…eep existing compat)
github-actions
bot
force-pushed
the
compathelper/new_version/2024-08-21-00-21-13-220-00293201790
branch
from
3bf68e0 to
fdc0661
Compare
|
This needs MTK to update to BifurcationKit .4 first |
|
@TorkelE could you update the BifurcationKit extension now? MTK has updated to the newest version and dropped support for the version we have, giving us some issues (for example, we can't use the latest MTK anymore in our docs, and I guess maybe in our tests). |
|
It's a breaking change too so supporting both is a bit hard, but we can have versioned |
|
Only supporting 0.4 is fine; that wasn’t meant to be a complaint. We just need to update our wrapper around the MTK extension, and maybe the doc examples if the usage has changed. Since the next Catalyst is breaking it seems fine to drop v3 versions. |
isaacsas
deleted the
compathelper/new_version/2024-08-21-00-21-13-220-00293201790
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
BifurcationKitpackage from0.3to0.3, 0.4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.