Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #1098

Merged
merged 7 commits into from
Oct 29, 2024
Merged

fix tests #1098

merged 7 commits into from
Oct 29, 2024

Conversation

isaacsas
Copy link
Member

No description provided.

@isaacsas
Copy link
Member Author

isaacsas commented Oct 28, 2024

@AayushSabharwal this seems to be a real and new failure related to remake: https://github.com/SciML/Catalyst.jl/actions/runs/11560966175/job/32178950735?pr=1098#step:6:1033

Are some of the types of symbolic maps being tested there no longer supported? (It mixes vectors, tuples, dicts, with symbolic and symbol maps.)

@isaacsas
Copy link
Member Author

These tests were passing as of earlier today I think.

@isaacsas
Copy link
Member Author

Here is one error we get:

ERROR: LoadError: TypeError: in validate_parameter_type, in Parameter Γ[1], expected Real, got a value of type SymbolicUtils.BasicSymbolic{Real}
Stacktrace:
  [1] validate_parameter_type(ic::ModelingToolkit.IndexCache, stype::Type, sz::Tuple{}, sym::SymbolicUtils.BasicSymbolic{…}, index::ModelingToolkit.ParameterIndex{…}, val::SymbolicUtils.BasicSymbolic{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/duznJ/src/systems/parameter_buffer.jl:479
  [2] validate_parameter_type(ic::ModelingToolkit.IndexCache, p::SymbolicUtils.BasicSymbolic{…}, idx::ModelingToolkit.ParameterIndex{…}, val::SymbolicUtils.BasicSymbolic{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/duznJ/src/systems/parameter_buffer.jl:432
  [3] (::ModelingToolkit.var"#handle_parameter#184")(ic::ModelingToolkit.IndexCache, sym::SymbolicUtils.BasicSymbolic{…}, idx::ModelingToolkit.ParameterIndex{…}, val::SymbolicUtils.BasicSymbolic{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/duznJ/src/systems/parameter_buffer.jl:505
  [4] _remake_buffer(indp::ODEProblem{…}, oldbuf::MTKParameters{…}, idxs::Base.KeySet{…}, vals::Base.ValueIterator{…}; validate::Bool)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/duznJ/src/systems/parameter_buffer.jl:530
  [5] _remake_buffer
    @ ~/.julia/packages/ModelingToolkit/duznJ/src/systems/parameter_buffer.jl:495 [inlined]
  [6] remake_buffer
    @ ~/.julia/packages/ModelingToolkit/duznJ/src/systems/parameter_buffer.jl:493 [inlined]
  [7] _updated_u0_p_symmap(prob::ODEProblem{…}, u0::Dict{…}, ::Val{…}, p::Dict{…}, ::Val{…}, t0::Int64)
    @ SciMLBase ~/.julia/packages/SciMLBase/j3YjA/src/remake.jl:716
  [8] _updated_u0_p_internal(prob::ODEProblem{…}, u0::Vector{…}, p::Vector{…}, t0::Int64; interpret_symbolicmap::Bool, use_defaults::Bool)
    @ SciMLBase ~/.julia/packages/SciMLBase/j3YjA/src/remake.jl:565
  [9] _updated_u0_p_internal
    @ ~/.julia/packages/SciMLBase/j3YjA/src/remake.jl:550 [inlined]
 [10] #updated_u0_p#729
    @ ~/.julia/packages/SciMLBase/j3YjA/src/remake.jl:740 [inlined]
 [11] updated_u0_p
    @ ~/.julia/packages/SciMLBase/j3YjA/src/remake.jl:720 [inlined]
 [12] remake(prob::ODEProblem{…}; f::Missing, u0::Vector{…}, tspan::Missing, p::Vector{…}, kwargs::Missing, interpret_symbolicmap::Bool, build_initializeprob::Bool, use_defaults::Bool, _kwargs::@Kwargs{})
    @ SciMLBase ~/.julia/packages/SciMLBase/j3YjA/src/remake.jl:122
 [13] steady_state_stability(u::Vector{…}, rs::ReactionSystem{…}, ps::Vector{…}; tol::Float64, ss_jac::ODEProblem{…})
    @ Catalyst ~/.julia/dev/Catalyst/src/steady_state_stability.jl:66
 [14] steady_state_stability(u::Vector{Float64}, rs::ReactionSystem{Catalyst.NetworkProperties{…}}, ps::Vector{Pair{…}})
    @ Catalyst ~/.julia/dev/Catalyst/src/steady_state_stability.jl:47
 [15] #63
    @ ./none:0 [inlined]
 [16] iterate
    @ ./generator.jl:48 [inlined]
 [17] collect(itr::Base.Generator{Vector{Vector{…}}, var"#63#65"{ReactionSystem{…}, Vector{…}}})
    @ Base ./array.jl:780
 [18] top-level scope
    @ ~/.julia/dev/Catalyst/test/extensions/stability_computation.jl:77
in expression starting at /Users/isaacsas/.julia/dev/Catalyst/test/extensions/stability_computation.jl:53
Some type information was truncated. Use `show(err)` to see complete types.

It seems to be occurring even when passing Symbolic maps.

@isaacsas isaacsas merged commit 0b4092e into SciML:master Oct 29, 2024
13 checks passed
@isaacsas isaacsas deleted the update_tests branch October 29, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant