GraphMakie update #1115
GraphMakie update #1115
Conversation
|
The first and third look great! The second is a bit strange. Do you want to tweak the layouts more in the PR, or get it merged as is and update later? (I ask as I'll review it sooner in the latter case, or wait till you say you are done in the former case). |
|
Also, is this based on the current master? I thought I had removed BifurcationKit there so the docs build but this seems to be crashing on it. |
|
Probably just merge this one as is and I'll look more at it in a follow-up. Also just rebased it, it seems like the remote branch was based on an earlier master commit |
|
It may still fail -- I have another PR that is completely removing Bifkit, so it may need one more rebasing once that is merged (but if tests pass and docs build as is I'll merge after reviewing). |
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
|
@vyudu probably worth updating this to master now that the BifurcationKit PR is merged. That should hopefully have fixed some issues in tests and doc builds. |
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
Co-authored-by: Sam Isaacson <[email protected]>
|
@vyudu feel free to merge when done now. |
|
@vyudu ping -- are you done with this? Can we merge? |
|
I am yeah, we can merge
…On Mon, Nov 18, 2024 at 09:07 Sam Isaacson ***@***.***> wrote:
@vyudu <https://github.com/vyudu> ping -- are you done with this? Can we
merge?
—
Reply to this email directly, view it on GitHub
<#1115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAOXYHDOEUT3QIW24SZVQL2BHYCVAVCNFSM6AAAAABRZY42AGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTGE2DQNRTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Refactoring the Graphviz code into GraphMakie. Some plots generated:
Brusselator species-reaction graph
Brusselator complex graph
Repressilator species-reaction graph
Might be worth playing around with the layouts a bit more to see if we can make the edge-lengths for these graphs more consistent and have the layouts be more horizontal. Will work on updating the documentation in a follow-up.