Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialisation tests #1145

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix serialisation tests #1145

merged 1 commit into from
Dec 20, 2024

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Dec 17, 2024

There is still an MTK issue we need fixed (SciML/ModelingToolkit.jl#3275), but it seems like a clear bug, so have just references it and marked the corresponding test as broken.

@ChrisRackauckas
Copy link
Member

Yes that is indeed a bug.

@isaacsas
Copy link
Member

isaacsas commented Dec 20, 2024

@TorkelE this is fine with me to merge. The doc failure is unrelated.

@TorkelE TorkelE merged commit 0c45ddf into master Dec 20, 2024
12 of 13 checks passed
@TorkelE TorkelE deleted the fix_serialisation_tests branch December 20, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants