Reenable spatial tests #1146
Merged
Reenable spatial tests #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
commented
Dec 17, 2024
test/runtests.jl
Outdated
|
|
||
| # Test spatial plotting, using CairoMakie and GraphMakie | ||
| activate_extensions_env() | ||
| @time @safetestset "Lattice Simulation Plotting" begin include("extensions/lattice_simulation_plotting.jl") end |
There was a problem hiding this comment.
Figured while this was placed in an extension (to not require Makie stuff generally) it really is a part of the spatial stuff, so might make sense to move here?
(but I am also happy to have it in the previous place)
There was a problem hiding this comment.
I'd prefer to keep anything loading extensions in one place given the high frequency at which they seem to give failures, and to avoid blocking our other tests via extension related dependency issues.
There was a problem hiding this comment.
sounds good, will move it back then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have done this previously, but seems I missed it...