Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTK tests update #1153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MTK tests update #1153

wants to merge 3 commits into from

Conversation

TorkelE
Copy link
Member

@TorkelE TorkelE commented Dec 19, 2024

Went through the MTK tests, fixed some things. Unfortunatelye everything major that was broken still is.

@isaacsas
Copy link
Member

Feel free to merge if you are done and tests pass.

It might be good more generally to go through your various open issues on indexing and remake and collate them all into one, new, big issue in MTK? (Closing the old ones.) Just to give a bump on all this and to summarize where things stand today since that may not be clear to everyone.

@ChrisRackauckas
Copy link
Member

Yes. My understanding is that everything is done, so I would expect most of your issues close? It looks like we missed one symbolic+array part that you just highlighted, but hopefully that's the only part that slipped.

@TorkelE
Copy link
Member Author

TorkelE commented Dec 19, 2024

Yeah, I think I will need to do another write-up with summaries. I think there might have been some issues that was partially solved, but some follow-up sub cases wasn't.

@TorkelE
Copy link
Member Author

TorkelE commented Dec 19, 2024

Ok, turns out there was an additional thing which was fixed now actually :)

@TorkelE TorkelE mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants