Initiatie #662
Closed
Initiatie #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ai-maintainer[bot]](https://avatars.githubusercontent.com/in/339956?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution!
This pull request is too large for automated review.Reviewed with AI Maintainer
|
I’ll try to review the other this week, but why can’t you start working on it before merging? Just check out that branch and work from there… |
|
To be honest, it is mostly done, but I will work on some additional tests for it. Was a little bit unsure on how working on PRs that depended on other PRs would work, but I will look into it, thanks. |
|
Just make a branch off the PR’s branch and work there. Once the first PR gets merged the dependent PR can get updated to master and should only show the new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really just a version of #644, but where I have removed all the ODE stuff, and added some tests that do not depend on creating ODEsystems. Merging this one would enable us to start working on the Jump stuff (which shares this with the ODE).
If #644 cannot be handled soon, then maybe we could try and merge this one, and we could create the spatial Jump PR (which has already been removed from #644).