-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "srcd/sl.jl" file #985
base: master
Are you sure you want to change the base?
Changes from 14 commits
efd44be
d2985c0
b06068f
5cc8f41
15273f1
b105b3e
1324428
71c9b5c
9ab9290
d45f0a7
b6ba044
cdac225
ea9aae3
7084133
a6b4c3a
160668f
9c265ee
34fc2c0
e9fa7ba
37ea1d9
87464f7
8156eca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,7 +86,7 @@ function make_compound(expr) | |
# Cannot extract directly using e.g. "getfield.(composition, :reactant)" because then | ||
# we get something like :([:C, :O]), rather than :([C, O]). | ||
composition = Catalyst.recursive_find_reactants!(expr.args[3], 1, | ||
Vector{ReactantStruct}(undef, 0)) | ||
Vector{ReactantInternal}(undef, 0)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about DSLReactant and DSLReaction? That makes clear their intended use case. |
||
components = :([]) # Becomes something like :([C, O]). | ||
coefficients = :([]) # Becomes something like :([1, 2]). | ||
for comp in composition | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function is used frequenty, and even more frequently when debugging code. Figured it made sense to import directly.