-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update yank section #36
base: master
Are you sure you want to change the base?
Conversation
Some comments from @StefanKarpinski on slack regarding the current permissible context for yanking:
And in response to: "But the readmes for general registry and ColPrac still both say to yank if you register a version with too wide compat bounds"
|
See also: Add guidance recommending yanking in General part 1: JuliaRegistries/General#102636 part 2: JuliaRegistries/General#104800 Ongoing difficulties of retroactive compat bounds adjustment: JuliaRegistries/General#104849 Parallel PR to General: JuliaRegistries/General#106278 I recommend that this PR follows the course of JuliaRegistries/General#106278, whatever that happens to be. |
But in practice compat bounds are preferred, and yanks are rejected: These guidelines should match practice? |
That is inconsistent with what's normally done. Normally the compat bounds are not manually updated. As @LilithHafner points out, it's recommended that devs don't manually muck with compat bounds like that because there's many issues that can crop up and no tools. That's just weird. That should've been a yank. |
See comments by @StefanKarpinsky above too... he said compat bounds! This is all very confusing. |
That's not how it's generally done in General though? Compat bounds changes to General are not merged because they aren't even adequately tested: you have to manually test whether the registry version you get will be installable. If you do it wrong then CI can pass but you can then crash all installations. That's why it stopped being recommended. |
The compat changes above were first reccomended and then merged by @giordano The yank was closed. I had another yank merged only after seriously pestering people on slack. (I prefer the yank too Im just trying to resolve guidelines with practical experience) |
yanked = true
is rarely merged in the general registry these days, so we should edit the recomendations to point towards editing Compat.toml instead.Possible a concrete example will help here?