Only allow adding data when safetycopy = false

SciML · Jul 3, 2024 · 7cb9ef8 · 7cb9ef8
1 parent 8410033
commit 7cb9ef8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/DataInterpolations.jl b/src/DataInterpolations.jl
@@ -81,6 +81,12 @@ function Base.showerror(io::IO, e::MustCopyError)
     print(io, MUST_COPY_ERROR)
 end
 
+const UNSAFE_ADD_DATA_ERROR = "Can only add data to the interpolation if safetycopy = false."
+struct UnsafeAddDataError <: Exception end
+function Base.showerror(io::IO, e::UnsafeAddDataError)
+    print(io, UNSAFE_ADD_DATA_ERROR) 
+end
+
 export LinearInterpolation, QuadraticInterpolation, LagrangeInterpolation,
        AkimaInterpolation, ConstantInterpolation, QuadraticSpline, CubicSpline,
        BSplineInterpolation, BSplineApprox, CubicHermiteSpline,

diff --git a/src/online.jl b/src/online.jl
@@ -1,6 +1,7 @@
 import Base: append!, push!
 
 function push!(A::LinearInterpolation{U, T}, u::eltype(U), t::eltype(T)) where {U, T}
+    A.safetycopy && throw(UnsafeAddDataError())
     push!(A.u.parent, u)
     push!(A.t.parent, t)
     slope = LinearInterpolationParameters(A.u, A.t, length(A.t) - 1)
@@ -9,6 +10,7 @@ function push!(A::LinearInterpolation{U, T}, u::eltype(U), t::eltype(T)) where {
 end
 
 function push!(A::QuadraticInterpolation{U, T}, u::eltype(U), t::eltype(T)) where {U, T}
+    A.safetycopy && throw(UnsafeAddDataError())
     push!(A.u.parent, u)
     push!(A.t.parent, t)
     l₀, l₁, l₂ = QuadraticInterpolationParameters(A.u, A.t, length(A.t) - 2)
@@ -19,6 +21,7 @@ function push!(A::QuadraticInterpolation{U, T}, u::eltype(U), t::eltype(T)) wher
 end
 
 function push!(A::ConstantInterpolation{U, T}, u::eltype(U), t::eltype(T)) where {U, T}
+    A.safetycopy && throw(UnsafeAddDataError())
     push!(A.u.parent, u)
     push!(A.t.parent, t)
     A
@@ -27,6 +30,7 @@ end
 function append!(
         A::LinearInterpolation{ReadOnlyVector{eltypeU, U}, ReadOnlyVector{eltypeT, T}}, u::U, t::T) where {
         eltypeU, U, eltypeT, T}
+    A.safetycopy && throw(UnsafeAddDataError())
     length_old = length(A.t)
     u, t = munge_data(u, t, true)
     append!(A.u.parent, u)
@@ -40,6 +44,7 @@ end
 function append!(
         A::ConstantInterpolation{ReadOnlyVector{eltypeU, U}, ReadOnlyVector{eltypeT, T}}, u::U, t::T) where {
         eltypeU, U, eltypeT, T}
+    A.safetycopy && throw(UnsafeAddDataError())
     u, t = munge_data(u, t, true)
     append!(A.u.parent, u)
     append!(A.t.parent, t)
@@ -49,6 +54,7 @@ end
 function append!(
         A::QuadraticInterpolation{ReadOnlyVector{eltypeU, U}, ReadOnlyVector{eltypeT, T}}, u::U, t::T) where {
         eltypeU, U, eltypeT, T}
+    A.safetycopy && throw(UnsafeAddDataError())
     length_old = length(A.t)
     u, t = munge_data(u, t, true)
     append!(A.u.parent, u)

diff --git a/test/online_tests.jl b/test/online_tests.jl
@@ -9,7 +9,7 @@ u2 = Float64[1, 2, 1]
 ts = 1.0:0.5:6.0
 
 for method in [LinearInterpolation, QuadraticInterpolation, ConstantInterpolation]
-    func1 = method(u1, t1)
+    func1 = method(u1, t1; safetycopy = false)
     append!(func1, u2, t2)
     func2 = method(vcat(u1, u2), vcat(t1, t2))
     @test func1.u == func2.u