Merge pull request #230 from SciML/jac

Promote element type for ForwardDiff jacobians
SciML · Mar 3, 2024 · 8d9baeb · 8d9baeb
2 parents d121990 + 29256d3
commit 8d9baeb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/DataInterpolations.jl b/src/DataInterpolations.jl
@@ -29,7 +29,7 @@ include("show.jl")
 
 (interp::AbstractInterpolation)(t::Number) = _interpolate(interp, t)
 (interp::AbstractInterpolation)(t::Number, i::Integer) = _interpolate(interp, t, i)
-(interp::AbstractInterpolation)(t::AbstractVector) = interp(similar(t, eltype(interp)), t)
+(interp::AbstractInterpolation)(t::AbstractVector) = interp(similar(t, promote_type(eltype(interp), eltype(t))), t)
 function (interp::AbstractInterpolation)(u::AbstractVector, t::AbstractVector)
     iguess = firstindex(interp.t)
     @inbounds for i in eachindex(u, t)

diff --git a/test/derivative_tests.jl b/test/derivative_tests.jl
@@ -219,3 +219,15 @@ end
     ts = 0.0:0.1:1.0
     @test all(map(ti -> symfunc(ti) == derivative(f, ti), ts))
 end
+
+@testset "Jacobian tests" begin
+    u = rand(5)
+    t = 0:4
+    interp = LinearInterpolation(u, t,extrapolate=true)
+    grad1 = ForwardDiff.derivative(interp,2.4)
+
+    myvec = rand(20).*4.0
+    interp(myvec)
+
+    grad = ForwardDiff.jacobian(interp,myvec)
+end