-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zygote support broke in new release #298
Comments
@SouthEndMusic, can you look into this as you were working on #289? |
It's hard to deduce from the link what exactly is failing. Which derivatives are being computed? What is desired behavior? From working on #289 I know that differentiating w.r.t. Regarding #289: I've managed to get the Zygote gradients working again by writing custom |
If the rule exists then we should add it and use it. I just said I personally wasn't going to spend much timing optimizing Zygote rules, but we shouldn't regress Zygote support. |
I am still seeing some failures after updating to v6 https://github.com/LuxDL/Boltz.jl/actions/runs/10240025636/job/28326309967?pr=45#step:6:716 |
Interesting, @SouthEndMusic is this a different case then the ones you looked at? |
Could be, I only looked at |
@avik-pal can you specify what type of |
It is a vector of arrays |
I made a PR and made it work in the case that |
See https://github.com/LuxDL/LuxLib.jl/actions/runs/9965073839/job/27534650459?pr=86#step:6:2929. Started showing up on update.
Probably needs a @non_differentiable on
methods
The text was updated successfully, but these errors were encountered: