-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor parameter caching + add Zygote tests #315
Merged
ChrisRackauckas
merged 11 commits into
SciML:master
from
SouthEndMusic:cache_parameters_opt_in
Jul 28, 2024
Merged
Refactor parameter caching + add Zygote tests #315
ChrisRackauckas
merged 11 commits into
SciML:master
from
SouthEndMusic:cache_parameters_opt_in
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
How can I fix the Zygote compat? |
You can only compat weakdeps or deps. So added as a weakdep if we want the compat. |
I've added tests for I think everything that was compatible with Zygote before. I've added some examples in |
ChrisRackauckas
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298
Fixes #301
#289 can be a follow-up. Gradients w.r.t. u for
QuadraticSpline
are not broken anymore, but they are slow as mentioned in the issue.The refactor includes:
u
andt
. We could if desired allow this with a dedicated interface which updates the parameters automatically. When parameters are not cached, they are computed on demand with the same functions.ReadOnlyArray
wrappers are removed, which simplifies the type parameters. I also noticed an inconsistency where I forgot to do it for integral inverse interpolations in the first placesafetycopy
as an option is removed againZygote:
u
of the data points for where that is supported (again).