fix(bounds): allow interpolation on bounds of time #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure I am following you. It works at the boundary points and this PR would make it error on those points. Can you provide an MWE where it is erroring for you? |
|
Yeah, I was mistaken about the order of operation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one tries to call interpolation for the extremities of the timespan for which the splines are fit, we get the
ExtrapolationErrorwhereas it isn't actually doing extrapolation. This relaxes the checks for where we query to include those bounds.Perhaps better checks are needed for when we query with something not time (i.e not linear, sorted, or monotonic)