Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derivatives for RegularizationSmooth and Curvefit #204

Merged

Conversation

sathvikbhagavan
Copy link
Member

@sathvikbhagavan sathvikbhagavan commented Nov 6, 2023

This PR does the following:

  1. Add derivatives for RegularizationSmooth using derivatives of CubicSplines as it fits a CubicSpline after solving the optimization problem
  2. Add derivatives for Curvefit using ForwardDiff
  3. Added tests for both
  4. Added extrapolate keyword to both to make it consistent with other methods
  5. Reorganized the extension files for more consistency
  6. Formatted the repo

Partial fix towards #175

@sathvikbhagavan sathvikbhagavan force-pushed the sb/add_derivative_reg_curvefit branch from eb56eb6 to ef7d067 Compare November 6, 2023 18:13
@sathvikbhagavan sathvikbhagavan force-pushed the sb/add_derivative_reg_curvefit branch from ef7d067 to f6f86e0 Compare November 6, 2023 18:14
@ChrisRackauckas ChrisRackauckas merged commit 16f2bbf into SciML:master Nov 7, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants