Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos CI #209

Merged
merged 1 commit into from
Dec 4, 2023
Merged

typos CI #209

merged 1 commit into from
Dec 4, 2023

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

@sathvikbhagavan
Copy link
Member

Does this check typos for docs as well?

@ArnoStrouwen
Copy link
Member Author

Yes. It is just less likely to find them there, since I already went over those manually before.

@ChrisRackauckas ChrisRackauckas merged commit 8d935fe into SciML:master Dec 4, 2023
8 checks passed
@ChrisRackauckas
Copy link
Member

What's the reason this one didn't get Aqua?

@ArnoStrouwen
Copy link
Member Author

The Aqua PRs take too much time, and many are blocked by pfitzseb/TreeViews.jl#3.
I'll loop over the repos a second time in a more leisurely pace after typos is done.

@ArnoStrouwen ArnoStrouwen deleted the typos branch December 4, 2023 14:04
@ChrisRackauckas
Copy link
Member

What package uses TreeViews? I thought it was removed awhile back?

@ArnoStrouwen
Copy link
Member Author

I think it is SciML/MultiScaleArrays.jl#83
and I also got the same error at Symbolics, but I did not confirm it was TreeViews that caused it.

@sathvikbhagavan
Copy link
Member

sathvikbhagavan commented Dec 4, 2023

Searching in github, it is also used in JumpProcesses.jl here apart from MultiScaleArrays

@ChrisRackauckas
Copy link
Member

We should remove all overloads of that. It only applies to Juno/Atom which is long gone now.

@sathvikbhagavan
Copy link
Member

JumpProcesses - SciML/JumpProcesses.jl#375
MultiScaleArrays - SciML/MultiScaleArrays.jl#84

@ArnoStrouwen
Copy link
Member Author

@sathvikbhagavan
Copy link
Member

Symbolics - JuliaSymbolics/Symbolics.jl#1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants