fix: CubicSpline's natural boundary conditions #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #234
Now we get the same outputs as scipy
https://en.wikiversity.org/wiki/Cubic_Spline_Interpolation
The first entry of the third column and last entry of first column in the tridiagonal matrix should have been zero.
For the tests, the polynomial mentioned in https://github.com/SciML/DataInterpolations.jl/blob/master/test/interpolation_tests.jl#L501 is not correct for natural boundary condition. Found the right ones in https://tools.timodenk.com/cubic-spline-interpolation