fix: get element type from interp.u instead of interp
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathvikbhagavan
force-pushed
the
sb/eltype
branch
from
373d920 to
64b3092
Compare
|
Not sure why Symbolics.jl is failing to precompile - https://github.com/SciML/DataInterpolations.jl/actions/runs/9316593135/job/25645177538?pr=254#step:6:376 |
sathvikbhagavan
force-pushed
the
sb/eltype
branch
from
64b3092 to
4db3b57
Compare
|
Depwarns are turned to errors. I'll handle this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #253
In DataInterpolations@v4,
eltype(interp)returnedeltype(interp.u)as it subtypedAbstractVectorof type which is the eltype ofinterp.uIn DataInterpolations@v5,
eltype(interp)returnsAnyas the subtyping to AbstractVector is removed, hence the issue. Fixing it to useeltype(interp.u).Added a few tests to ensure the returned vectors have the same type as
interp.u.