-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cubic & Quintic Hermite Spline #280
Cubic & Quintic Hermite Spline #280
Conversation
I like it, but two things.
|
|
BTW, I think you've made significant contributions, and we just happen to be writing an article on DataInterpolations right now. Would you like to a be co-author? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Had some minor comments. Also can you add a few tests for checking parameter caches are set properly or not similar to my comment in #274?
That sounds interesting, what would that entail? |
We already have a JOSS paper review going on - openjournals/joss-reviews#6917 Can you make a PR adding your name and affiliation in https://github.com/SciML/DataInterpolations.jl/blob/master/joss/paper.md? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that typo.. LGTM!
Co-authored-by: Sathvik Bhagavan <[email protected]>
Fixes #218.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I am on a roll hacking around in this repository, so I decided to add the quintic Hermite interpolation as well (: