Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded Float64s in AkimaInterpolation #383

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

ChrisRackauckas
Copy link
Member

Just doing this from my phone to see if that's it. Missing tests and such, if someone can help that would be great.

Just doing this from my phone to see if that's it. Missing tests and such, if someone can help that would be great.
@DaniGlez
Copy link
Contributor

Works on the issue example, indeed.

@DaniGlez
Copy link
Contributor

DaniGlez commented Jan 28, 2025

Here's a test:

    # Test consistency between eltype(u) and type of the output
    u = Float32[-0.676367f0, 0.8449812f0, 1.2366607f0, -0.13347931f0, 1.9928657f0,
        -0.63596356f0, 0.76009744f0, -0.30632544f0, 0.34649512f0, -0.3846099f0]
    t = 0.1f0:0.1f0:1.0f0
    for extrapolation_flag in instances(ExtrapolationType.T)
        (extrapolation_flag == ExtrapolationType.None) && continue
        aki = AkimaInterpolation(u, t; extrapolation = extrapolation_flag)
        @test eltype(aki.([-2.0f0, 0.5f0, 3.0f0])) == Float32
    end

@ChrisRackauckas ChrisRackauckas merged commit 042cf04 into master Jan 31, 2025
16 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-2 branch January 31, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants