Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty solution in HistoryFunction correctly #290

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

devmotion
Copy link
Member

I ran into a weird issue in some private downstream code which ultimately I think points to a problem in the downstream code. However, even though I wasn't able to reproduce the problem with DelayDiffEq alone, I think we should fix the definition of the HistoryFunction: Currently, it performs unsafe indexing that is even annotated with @inbounds 😕

@ChrisRackauckas ChrisRackauckas merged commit 43201e7 into master Apr 24, 2024
10 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dw/historyfunction_empty_sol branch April 24, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants