Fix tests not not assume Rosenbrock23 doesn't W transform #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Sep 12, 2024
| @@ -15,13 +15,6 @@ using Test | |||
| nothing | |||
| end | |||
|
|
|||
| nWfacts = Ref(0) | |||
| function Wfact(W, u, h, p, dtgamma, t) | |||
There was a problem hiding this comment.
Why does this PR remove the Wfact tests? We could skip them for Rosenbrock23 if needed but for TRBDF2 they should still work, shouldn't they?
There was a problem hiding this comment.
Wfact only gets used when transform=false and rosenbrock23 was the last solver that didn't w-transform.
There was a problem hiding this comment.
once I merge both of the OrdinaryDiffEq prs, I'm going to open a PR that deprecates or removes W_fact from ODEFuncton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with SciML/OrdinaryDiffEq.jl#2307 Rosenbrock23 (like everything else) uses the W-transform so this switches the test to test Rodas5P (since otherwise there isn't a sequencing that would keep CI green).