Merge pull request #1059 from SciML/nested_sol

Fix solutions nested in structs for forwarddiff
SciML · Jun 16, 2024 · cdbe856 · cdbe856
2 parents ffe1600 + 4f0c45d
commit cdbe856
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/forwarddiff.jl b/src/forwarddiff.jl
@@ -181,6 +181,12 @@ function anyeltypedual(x::Type{T},
                                                               ForwardDiff.AbstractConfig}
     Any
 end
+
+function anyeltypedual(::Type{<:AbstractTimeseriesSolution{T, N}},
+        ::Type{Val{counter}} = Val{0}) where {T, N, counter}
+    anyeltypedual(T)
+end
+
 function anyeltypedual(x::ForwardDiff.DiffResults.DiffResult,
         ::Type{Val{counter}} = Val{0}) where {counter}
     Any

diff --git a/test/forwarddiff_dual_detection.jl b/test/forwarddiff_dual_detection.jl
@@ -335,3 +335,15 @@ ode = ODEProblem(f, [0.0, 0.0], (0, 1))
 @inferred DiffEqBase.anyeltypedual(ode)
 ode = NonlinearProblem(f, [0.0, 0.0], (0, 1))
 @inferred DiffEqBase.anyeltypedual(ode)
+
+# Issue https://github.com/SciML/DiffEqBase.jl/issues/1021
+f(u, p, t) = 1.01 * u
+struct Foo{T}
+    sol::T
+end
+u0 = 1 / 2
+tspan = (0.0, 1.0)
+prob = ODEProblem{false}(f, u0, tspan)
+foo = SciMLBase.build_solution(
+    prob, DiffEqBase.InternalEuler.FwdEulerAlg(), [u0, u0], [0.0, 1.0])
+DiffEqBase.anyeltypedual((; x = foo))