deprecate stats #948
Closed
deprecate stats #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can just forward it. Two steps:
That is non-breaking and will let it adjust over time, since there's 10 other solvers that will also need to update. |
|
I dismissed that idea because I thought it'd upend the dependency hierarchy but sure I'll do that after SciML/SciMLBase.jl#512 lands |
|
Supersceded by #949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is getting moved to SciMLBase. I'm not sure if this is the correct way to mark it deprecated. It seems
@deprecate_movedseems close but makes the current binding error.@deprecate_bindingactually requires the new symbol to exist. Hum.