Documenter 1.0 upgrade #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SDE example is only compatible with SciMLBase 2. There is also another error regarding a solver name that I don't know how to fix: GeneralMIRK4 |
|
Finally found the setting to get the buildkite working on PR. |
|
SciML/BoundaryValueDiffEq.jl#109 should be the only one left, and I hope it merges today. |
docs/src/tutorials/bvp_example.md
Outdated
| function bc2!(residual, u, p, t) # u[1] is the beginning of the time span, and u[end] is the ending | ||
| residual[1] = u[1][1] + pi / 2 # the solution at the beginning of the time span should be -pi/2 | ||
| residual[2] = u[end][1] - pi / 2 # the solution at the end of the time span should be pi/2 | ||
| function bc2!((resid_a, resid_b), (u_a, u_b), p, t) # u[1] is the beginning of the time span, and u[end] is the ending |
There was a problem hiding this comment.
@avik-pal is this not right?
avik-pal
requested changes
Oct 1, 2023
Co-authored-by: Avik Pal <[email protected]>
|
Looks like there's still more. @avik-pal can you complete this? Let's make sure that the constructors are "complete" before being set in stone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.