Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few docs cleanup #147

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Few docs cleanup #147

merged 3 commits into from
Jan 9, 2024

Conversation

sathvikbhagavan
Copy link
Member

Noticed doc build was failing on master - https://github.com/SciML/GlobalSensitivity.jl/actions/runs/7455890323/job/20285675728 because of link check.

I am not sure of the reason but curl of [sciencedirect.com](http://sciencedirect.com/) results in 403 error now

> curl -I <https://www.sciencedirect.com/>
HTTP/2 403
date: Tue, 09 Jan 2024 11:03:58 GMT
...

I have added a linkcheck_ignore for articles from sciencedirect referenced.

Also noticed a few examples were not run in the doc build - so changed it to running them.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ae0794) 92.85% compared to head (5a5a967) 92.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          11       11           
  Lines         840      840           
=======================================
  Hits          780      780           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02 Vaibhavdixit02 merged commit ffe5474 into SciML:master Jan 9, 2024
7 of 8 checks passed
@Vaibhavdixit02
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants