hotfix a few more default cases

SciML · Jun 5, 2023 · 45118a5 · 45118a5
1 parent 73a1395
commit 45118a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "LinearSolve"
 uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 authors = ["SciML"]
-version = "2.1.7"
+version = "2.1.8"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

diff --git a/src/factorization.jl b/src/factorization.jl
@@ -699,7 +699,8 @@ function init_cacheval(alg::UMFPACKFactorization, A, b, u, Pl, Pr, maxiters::Int
             return SuiteSparse.UMFPACK.UmfpackLU(SparseMatrixCSC(size(A)..., getcolptr(A),
                                                                  rowvals(A), nonzeros(A)))
         end
-
+    elseif !(eltype(A) <: Union{Float32,Float64}) || !(eltype(b) <: Union{Float32,Float64})
+        return nothing # Cannot use Umfpack
     else
         @static if VERSION < v"1.9.0-DEV.1622"
             res = SuiteSparse.UMFPACK.UmfpackLU(C_NULL, C_NULL, 0, 0,
@@ -782,6 +783,8 @@ function init_cacheval(alg::KLUFactorization, A, b, u, Pl, Pr, maxiters::Int, ab
     if typeof(A) <: SparseArrays.AbstractSparseArray
         return KLU.KLUFactorization(SparseMatrixCSC(size(A)..., getcolptr(A), rowvals(A),
                                                     nonzeros(A)))
+    elseif !(eltype(A) <: Union{Float32,Float64}) || !(eltype(b) <: Union{Float32,Float64})
+        return nothing # Cannot use KLU
     else
         return KLU.KLUFactorization(SparseMatrixCSC(0, 0, [1], Int64[], eltype(A)[]))
     end
@@ -1102,7 +1105,7 @@ end
 
 function SciMLBase.solve!(cache::LinearCache, alg::DiagonalFactorization;
                           kwargs...)
-    A = cache.A
+    A = convert(AbstractMatrix, cache.A)
     if cache.u isa Vector && cache.b isa Vector
         @simd ivdep for i in eachindex(cache.u)
             cache.u[i] = A.diag[i] \ cache.b[i]