Error on unsupported return type and relax tolerence on tests to avoi…

…d random failures
SciML · Nov 7, 2023 · 585cbb8 · 585cbb8
1 parent 3a3102b
commit 585cbb8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ext/LinearSolveEnzymeExt.jl b/ext/LinearSolveEnzymeExt.jl
@@ -23,6 +23,7 @@ function EnzymeCore.EnzymeRules.forward(func::Const{typeof(LinearSolve.init)}, :
     elseif RT <: Duplicated
         return Duplicated(res, dres)
     end
+    error("Unsupported return type $RT")
 end
 
 function EnzymeCore.EnzymeRules.forward(func::Const{typeof(LinearSolve.solve!)}, ::Type{RT}, linsolve::EnzymeCore.Annotation{LP}; kwargs...) where {RT, LP <: LinearSolve.LinearCache}

diff --git a/test/enzyme.jl b/test/enzyme.jl
@@ -193,7 +193,7 @@ for alg in (
     end |> collect
     @show en_jac
 
-    @test en_jac ≈ fd_jac rtol=1e-6
+    @test en_jac ≈ fd_jac rtol=1e-4
 
     function fA(A)
         prob = LinearProblem(A, b1)
@@ -213,5 +213,5 @@ for alg in (
     end |> collect
     @show en_jac
 
-    @test en_jac ≈ fd_jac rtol=1e-6
+    @test en_jac ≈ fd_jac rtol=1e-4
 end